Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use root module when determining UUID in @artifact_str #45392

Merged
merged 1 commit into from
May 21, 2022
Merged

Use root module when determining UUID in @artifact_str #45392

merged 1 commit into from
May 21, 2022

Conversation

zickgraf
Copy link
Contributor

Otherwise, overrides do not trigger when using artifact"..." inside a submodule.

@zickgraf
Use root module when determining UUID in @artifact_str
d2a9170 
Otherwise, overrides do not trigger when using `artifact"..."` inside a
submodule.
vtjnash
vtjnash reviewed May 20, 2022
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@staticfloat staticfloat merged commit 9b106ad into JuliaLang:master May 21, 2022
@fredrikekre fredrikekre added backport 1.6 Change should be backported to release-1.6 backport 1.7 backport 1.8 Change should be backported to release-1.8 labels May 21, 2022
KristofferC pushed a commit that referenced this pull request May 23, 2022
@zickgraf
Use root module when determining UUID in @artifact_str (#45392)
dea62ee 
Otherwise, overrides do not trigger when using `artifact"..."` inside a
submodule.

(cherry picked from commit 9b106ad)
@KristofferC KristofferC mentioned this pull request May 23, 2022
Merged
67 tasks
KristofferC pushed a commit that referenced this pull request May 23, 2022
@zickgraf
Use root module when determining UUID in @artifact_str (#45392)
87a22e4 
Otherwise, overrides do not trigger when using `artifact"..."` inside a
submodule.

(cherry picked from commit 9b106ad)
@KristofferC KristofferC mentioned this pull request May 23, 2022
Merged
45 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 26, 2022
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 6, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@zickgraf
Use root module when determining UUID in @artifact_str (#45392)
b56bad5 
Otherwise, overrides do not trigger when using `artifact"..."` inside a
submodule.

(cherry picked from commit 9b106ad)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@zickgraf @staticfloat
Use root module when determining UUID in @artifact_str (#45392)
f562374 
Otherwise, overrides do not trigger when using `artifact"..."` inside a
submodule.

(cherry picked from commit 9b106ad)
@LilithHafner LilithHafner mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

@staticfloat staticfloat Awaiting requested review from staticfloat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zickgraf @vtjnash @staticfloat @KristofferC @fredrikekre