Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing field type initialization vars #44797

Merged
merged 1 commit into from
Apr 7, 2022
Merged

fix missing field type initialization vars #44797

merged 1 commit into from
Apr 7, 2022

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Mar 29, 2022

We were accidentally passing the start of the list instead of the end of
the list, resulting in some values passing through uninitialized.

Fix #42297 regression

@vtjnash
fix missing field type initialization vars
eaaca61 
We were accidentally passing the start of the list instead of the end of
the list, resulting in some values passing through uninitialized.

Fix #42297 regression
@vtjnash vtjnash added backport 1.6 Change should be backported to release-1.6 backport 1.7 backport 1.8 Change should be backported to release-1.8 labels Mar 29, 2022
@vtjnash vtjnash merged commit 5f2abf6 into master Apr 7, 2022
@vtjnash vtjnash deleted the jn/42297 branch April 7, 2022 17:48
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@vtjnash @KristofferC
fix missing field type initialization vars (#44797)
0972a38 
We were accidentally passing the start of the list instead of the end of
the list, resulting in some values passing through uninitialized.

Fix #42297 regression

(cherry picked from commit 5f2abf6)
@KristofferC KristofferC mentioned this pull request Apr 19, 2022
Merged
40 tasks
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@vtjnash @KristofferC
fix missing field type initialization vars (#44797)
7cfc43f 
We were accidentally passing the start of the list instead of the end of
the list, resulting in some values passing through uninitialized.

Fix #42297 regression

(cherry picked from commit 5f2abf6)
@KristofferC KristofferC mentioned this pull request Apr 19, 2022
Merged
67 tasks
KristofferC pushed a commit that referenced this pull request May 16, 2022
@vtjnash
fix missing field type initialization vars (#44797)
89b3c22 
We were accidentally passing the start of the list instead of the end of
the list, resulting in some values passing through uninitialized.

Fix #42297 regression

(cherry picked from commit 5f2abf6)
@KristofferC KristofferC mentioned this pull request May 16, 2022
Merged
45 tasks
@KristofferC KristofferC removed backport 1.8 Change should be backported to release-1.8 backport 1.7 labels May 26, 2022
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 6, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@vtjnash
fix missing field type initialization vars (#44797)
f543ec6 
We were accidentally passing the start of the list instead of the end of
the list, resulting in some values passing through uninitialized.

Fix #42297 regression

(cherry picked from commit 5f2abf6)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vtjnash @staticfloat
fix missing field type initialization vars (#44797)
89d850e 
We were accidentally passing the start of the list instead of the end of
the list, resulting in some values passing through uninitialized.

Fix #42297 regression

(cherry picked from commit 5f2abf6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order-dependent error in recursive data type constructor
2 participants
@vtjnash @KristofferC