effects: change the overlayed::Bool
property to nonoverlayed::Bool
#44786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current naming of
overlayed
is a bit confusing sinceoverlayed === true
, which is the conservative default value, actuallymeans "it may be overlayed" while
overlayed === false
means"this is absolutely not overlayed".
I think it should be named as
nonoverlayed
, and then a query name likeis_nonoverlayed
would be more sensible than the alternativeis_overlayed
, which actually should be something likecan_be_overlayed
.