Pass around effects during inference cacheing #44777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
approved these changes
Mar 28, 2022
vtjnash
approved these changes
Mar 28, 2022
DilumAluthge
removed
the
merge me
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Mar 29, 2022
aviatesk
added a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Mar 29, 2022
aviatesk
added a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Mar 29, 2022
KristofferC
pushed a commit
that referenced
this pull request
Mar 29, 2022
(cherry picked from commit d7782de)
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled this out of #44660 for use in JuliaDebug/Cthulhu.jl#281
The effects aren't actually used here, but this lets external inference consumers like Cthulhu properly grab effects while hooking onto
transform_result_for_cache.