Also trigger breakpoint on testset error #44652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Mar 17, 2022
Keno
added a commit
that referenced
this pull request
Mar 18, 2022
Fixes the test failure observed in #44652.
aviatesk
pushed a commit
that referenced
this pull request
Mar 19, 2022
Fixes the test failure observed in #44652.
vtjnash
previously requested changes
Mar 20, 2022
stdlib/Test/src/Test.jl
Outdated
| @@ -1435,6 +1436,7 @@ function testset_forloop(args, testloop, source) | |||
| err isa InterruptException && rethrow() | |||
| # Something in the test block threw an error. Count that as an | |||
| # error in this test set | |||
| ccall(:jl_test_failure_breakpoint, Cvoid, (Any,), err) | |||
There was a problem hiding this comment.
Inserting a ccall in a macro will force a large amount of additional compilation and corrupt our test heuristics here. Can we outline this?
aviatesk
pushed a commit
that referenced
this pull request
Jul 26, 2022
Fixes the test failure observed in #44652.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #44635 (comment)