Extend strides for ReshapedArray with strided parent.
#44507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was an oversight (regression) in #44027, right, following the discussion after that PR was merged? That commit appears to be in v1.8.0 also, so this may need backporting |
N5N3
force-pushed
the
ignore-sz1
branch
3 times, most recently
from
d07b00e
to
7a081cb
Compare
N5N3
changed the title
strides for ReshapedArray with strided parent.
47 tasks
This was referenced Mar 15, 2022
N5N3
force-pushed
the
ignore-sz1
branch
2 times, most recently
from
6f9f6ae
to
9c9d28e
Compare
This was referenced Mar 23, 2022
|
Is this PR ready to be merged? Or is there something holding it back? |
|
It's waiting for review. @timholy would you mind taking a quick look at it? |
Use `Base.merge_adjacent_dim` to perform vector layout check before BLAS call. style clean
It turns out `strides(a::StridedReinterpretArray)` won't call `Base.size_to_strides` anymore after JuliaLang#44027. As it is dispatched to `strides(::NonReshapedReinterpretArray)`/`strides(::ReshapedReinterpretArray)`. This commit fix that regression.
36 tasks
|
Let's run tests again since it's been a while. |
|
Never mind @timholy. CI looks busy st present, maybe we need to rerun the test when it's free. |
|
I haven't been following CI lately, are these failures OK? If so would someone please merge? |
KristofferC
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Extend `strides(::ReshapedArray)` with non-contiguous strided parent * Make sure `strides(::StridedReinterpretArray)` calls `size_to_strides` Co-authored-by: Tim Holy <tim.holy@gmail.com> (cherry picked from commit 0d3aca4)
15 tasks
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
…44507) * Extend `strides(::ReshapedArray)` with non-contiguous strided parent * Make sure `strides(::StridedReinterpretArray)` calls `size_to_strides` Co-authored-by: Tim Holy <tim.holy@gmail.com>
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
…44507) * Extend `strides(::ReshapedArray)` with non-contiguous strided parent * Make sure `strides(::StridedReinterpretArray)` calls `size_to_strides` Co-authored-by: Tim Holy <tim.holy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44027 defined
strides(::ReshapedArray)for dense/stridedvector parents, where the dense check failed to cover inputs with size-1 dimension.With this PR,
stridesis extended to allReshapedArraywhose parent hasstridesdefined.And the memory layout check for vector inputs before BLAS call is fixed by code reuse.
Close #44497.