Do not allocate so many arrays in optimizer hot path #44492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: ``` julia> @time Cthulhu.mkinterp(TortureTest.run_test1, Tuple{Int}); 12.851312 seconds (89.76 M allocations: 12.845 GiB, 39.38% gc time) julia> @time Cthulhu.mkinterp(TortureTest.run_test1, Tuple{Int}); 10.862736 seconds (89.76 M allocations: 12.845 GiB, 26.90% gc time) ``` After: ``` julia> @time Cthulhu.mkinterp(TortureTest.run_test1, Tuple{Int}); 10.929275 seconds (59.01 M allocations: 10.987 GiB, 33.07% gc time) julia> @time Cthulhu.mkinterp(TortureTest.run_test1, Tuple{Int}); 8.635190 seconds (59.01 M allocations: 10.987 GiB, 20.06% gc time) ```
Keno
added a commit
that referenced
this pull request
Mar 7, 2022
With #44494, this cuts about 22M allocations (out of 59M) from the compiler benchmark in #44492. Without #44494, it still reduces the number of allocations, but not as much. This was originally optimized in 100666b, but the behavior of our compiler has changed to allow inling the Tuple{UseRef, Int} into the outer struct, forcing a reallocation on every iteration.
|
@nanosoldier |
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
vtjnash
approved these changes
Mar 8, 2022
ianatol
pushed a commit
to ianatol/julia
that referenced
this pull request
Mar 15, 2022
With JuliaLang#44494, this cuts about 22M allocations (out of 59M) from the compiler benchmark in JuliaLang#44492. Without JuliaLang#44494, it still reduces the number of allocations, but not as much. This was originally optimized in 100666b, but the behavior of our compiler has changed to allow inling the Tuple{UseRef, Int} into the outer struct, forcing a reallocation on every iteration.
Keno
added a commit
that referenced
this pull request
Mar 15, 2022
With #44494, this cuts about 22M allocations (out of 59M) from the compiler benchmark in #44492. Without #44494, it still reduces the number of allocations, but not as much. This was originally optimized in 100666b, but the behavior of our compiler has changed to allow inling the Tuple{UseRef, Int} into the outer struct, forcing a reallocation on every iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: