Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isdone for empty product iterators, fixes #43921 #43947

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Fix isdone for empty product iterators, fixes #43921 #43947

merged 2 commits into from
Nov 3, 2022

Conversation

sasi591
Copy link
Contributor

@sasi591 sasi591 commented Jan 27, 2022

Closes the issue #43921

@aviatesk
Copy link
Member

Add a test to check this functionality.

@fredrikekre fredrikekre changed the title Fix the issue #43921 Fix isdone for empty product iterators, fixes #43921 Jan 27, 2022
@fredrikekre fredrikekre added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Jan 27, 2022
@sostock sostock added the needs tests Unit tests are required for this change label Jan 27, 2022
This was referenced Feb 15, 2022
Merged
Merged
@KristofferC KristofferC mentioned this pull request May 16, 2022
Merged
45 tasks
@KristofferC KristofferC mentioned this pull request Jul 20, 2022
Closed
78 tasks
@KristofferC KristofferC added the backport 1.8 Change should be backported to release-1.8 label Nov 2, 2022
@KristofferC KristofferC added merge me PR is reviewed. Merge when all tests are passing and removed needs tests Unit tests are required for this change labels Nov 2, 2022
@DilumAluthge DilumAluthge merged commit b8a77da into JuliaLang:master Nov 3, 2022
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Nov 3, 2022
@KristofferC KristofferC mentioned this pull request Nov 8, 2022
Merged
26 tasks
@barucden barucden mentioned this pull request Nov 21, 2022
Closed
KristofferC pushed a commit that referenced this pull request Dec 14, 2022
@sasi591
Fix isdone for empty product iterators, fixes #43921 (#43947)
44b24dd 
* Fix the issue #43921

* add a test

Co-authored-by: Kristoffer <kcarlsson89@gmail.com>
(cherry picked from commit b8a77da)
KristofferC pushed a commit that referenced this pull request Dec 14, 2022
@sasi591
Fix isdone for empty product iterators, fixes #43921 (#43947)
6a09343 
* Fix the issue #43921

* add a test

Co-authored-by: Kristoffer <kcarlsson89@gmail.com>
(cherry picked from commit b8a77da)
KristofferC pushed a commit that referenced this pull request Dec 14, 2022
@sasi591
Fix isdone for empty product iterators, fixes #43921 (#43947)
a9a234c 
* Fix the issue #43921

* add a test

Co-authored-by: Kristoffer <kcarlsson89@gmail.com>
(cherry picked from commit b8a77da)
KristofferC pushed a commit that referenced this pull request Dec 14, 2022
@sasi591
Fix isdone for empty product iterators, fixes #43921 (#43947)
fd92d74 
* Fix the issue #43921

* add a test

Co-authored-by: Kristoffer <kcarlsson89@gmail.com>
(cherry picked from commit b8a77da)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Dec 16, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@sasi591
Fix isdone for empty product iterators, fixes #43921 (#43947)
84cb211 
* Fix the issue #43921

* add a test

Co-authored-by: Kristoffer <kcarlsson89@gmail.com>
(cherry picked from commit b8a77da)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@sasi591
Fix isdone for empty product iterators, fixes #43921 (#43947)
5e9bb06 
* Fix the issue #43921

* add a test

Co-authored-by: Kristoffer <kcarlsson89@gmail.com>
(cherry picked from commit b8a77da)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@sasi591
Fix isdone for empty product iterators, fixes #43921 (#43947)
1de58c4 
* Fix the issue #43921

* add a test

Co-authored-by: Kristoffer <kcarlsson89@gmail.com>
(cherry picked from commit b8a77da)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@sasi591
Fix isdone for empty product iterators, fixes #43921 (#43947)
e5f9fdd 
* Fix the issue #43921

* add a test

Co-authored-by: Kristoffer <kcarlsson89@gmail.com>
(cherry picked from commit b8a77da)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@sasi591 @staticfloat
Fix isdone for empty product iterators, fixes #43921 (#43947)
3c662dc 
* Fix the issue #43921

* add a test

Co-authored-by: Kristoffer <kcarlsson89@gmail.com>
(cherry picked from commit b8a77da)
KristofferC pushed a commit that referenced this pull request Oct 10, 2023
@sasi591 @KristofferC
Fix isdone for empty product iterators, fixes #43921 (#43947)
3cfa748 
* Fix the issue #43921

* add a test

Co-authored-by: Kristoffer <kcarlsson89@gmail.com>
(cherry picked from commit b8a77da)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sasi591 @aviatesk @KristofferC @DilumAluthge @fredrikekre @sostock