Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reflection: use a real world for lookups #43695

Merged
merged 3 commits into from
Jan 8, 2022
Merged

reflection: use a real world for lookups #43695

merged 3 commits into from
Jan 8, 2022

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jan 7, 2022

Using a fake world was a bit of a hack, but may give odd results sometimes.

@vtjnash
reflection: use a real world for lookups
21dd7e1 
Using a fake world was a bit of a hack, but may give odd results sometimes.
aviatesk
aviatesk reviewed Jan 7, 2022
View reviewed changes
Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also would like to remove _methods_by_ftype(@nospecialize(t), mt::Union{Core.MethodTable, Nothing}, lim::Int, world::UInt, ambig::Bool, min::Array{UInt,1}, max::Array{UInt,1}, has_ambig::Array{Int32,1}) if this method isn't used anymore.

stdlib/Test/src/Test.jl Outdated Show resolved Hide resolved
@vtjnash @aviatesk
Update stdlib/Test/src/Test.jl
42c095f 
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
aviatesk
aviatesk reviewed Jan 7, 2022
View reviewed changes
stdlib/Test/src/Test.jl Outdated Show resolved Hide resolved
@aviatesk aviatesk merged commit dacd16f into master Jan 8, 2022
@aviatesk aviatesk deleted the jn/real-world-lookups branch January 8, 2022 04:38
@aviatesk aviatesk mentioned this pull request Jan 8, 2022
Merged
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@vtjnash @LilithHafner
reflection: use a real world for lookups (JuliaLang#43695)
72f02df
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@vtjnash @LilithHafner
reflection: use a real world for lookups (JuliaLang#43695)
52b86d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviatesk aviatesk aviatesk left review comments

@vchuravy vchuravy vchuravy approved these changes

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtjnash @vchuravy @JeffBezanson @aviatesk