-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for package name in [extras]
for Preferences
#43361
Conversation
When Preferences.jl set's a preferences in a non-top-level package, it adds that package to the `[extras]` entries in the project path. Package loading should have used thhose entries to map the module uuid to the key name in the Preferences.toml Fixes JuliaPackaging/Preferences.jl#24
@KristofferC found the right
but we simply forgotten to look into |
Co-authored-by: Elliot Saba <staticfloat@gmail.com>
* Look for package name in `[extras]` When Preferences.jl set's a preferences in a non-top-level package, it adds that package to the `[extras]` entries in the project path. Package loading should have used thhose entries to map the module uuid to the key name in the Preferences.toml Fixes JuliaPackaging/Preferences.jl#24 Co-authored-by: Elliot Saba <staticfloat@gmail.com> (cherry picked from commit 8197c41)
* Look for package name in `[extras]` When Preferences.jl set's a preferences in a non-top-level package, it adds that package to the `[extras]` entries in the project path. Package loading should have used thhose entries to map the module uuid to the key name in the Preferences.toml Fixes JuliaPackaging/Preferences.jl#24 Co-authored-by: Elliot Saba <staticfloat@gmail.com> (cherry picked from commit 8197c41)
* Look for package name in `[extras]` When Preferences.jl set's a preferences in a non-top-level package, it adds that package to the `[extras]` entries in the project path. Package loading should have used thhose entries to map the module uuid to the key name in the Preferences.toml Fixes JuliaPackaging/Preferences.jl#24 Co-authored-by: Elliot Saba <staticfloat@gmail.com> (cherry picked from commit 8197c41)
* Look for package name in `[extras]` When Preferences.jl set's a preferences in a non-top-level package, it adds that package to the `[extras]` entries in the project path. Package loading should have used thhose entries to map the module uuid to the key name in the Preferences.toml Fixes JuliaPackaging/Preferences.jl#24 Co-authored-by: Elliot Saba <staticfloat@gmail.com>
* Look for package name in `[extras]` When Preferences.jl set's a preferences in a non-top-level package, it adds that package to the `[extras]` entries in the project path. Package loading should have used thhose entries to map the module uuid to the key name in the Preferences.toml Fixes JuliaPackaging/Preferences.jl#24 Co-authored-by: Elliot Saba <staticfloat@gmail.com>
* Look for package name in `[extras]` When Preferences.jl set's a preferences in a non-top-level package, it adds that package to the `[extras]` entries in the project path. Package loading should have used thhose entries to map the module uuid to the key name in the Preferences.toml Fixes JuliaPackaging/Preferences.jl#24 Co-authored-by: Elliot Saba <staticfloat@gmail.com> (cherry picked from commit 8197c41)
When Preferences.jl set's a preferences in a non-top-level package,
it adds that package to the
[extras]
entries in the project path.Package loading should have used thhose entries to map the module uuid
to the key name in the Preferences.toml
Fixes JuliaPackaging/Preferences.jl#24