Skip to content

Test: Fix indenting on verbose no-failure report #43251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IanButterworth
Copy link
Member

Fixes the indenting in verbose @testset printing when no failures/errors occur

Master

julia> @testset "Foo" verbose = true begin
           @testset "Barbarbarbarbar" begin
               @test true
           end
           @testset "Baz" begin
               @test true
           end
       end
Test Summary: | Pass  Total
Foo           |    2      2
  Barbarbarbarbar |    1      1
  Baz         |    1      1

This PR

julia> @testset "Foo" verbose = true begin
           @testset "Barbarbarbarbar" begin
               @test true
           end
           @testset "Baz" begin
               @test true
           end
       end
Test Summary:     | Pass  Total
Foo               |    2      2
  Barbarbarbarbar |    1      1
  Baz             |    1      1

@IanButterworth IanButterworth added testsystem The unit testing framework and Test stdlib stdlib Julia's standard library backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 29, 2021
@IanButterworth IanButterworth merged commit 6bea8e3 into JuliaLang:master Nov 29, 2021
@IanButterworth IanButterworth deleted the ib/test_verbose_indent branch November 29, 2021 23:44
KristofferC pushed a commit that referenced this pull request Dec 2, 2021
@KristofferC KristofferC mentioned this pull request Dec 2, 2021
29 tasks
KristofferC pushed a commit that referenced this pull request Dec 2, 2021
KristofferC pushed a commit that referenced this pull request Dec 2, 2021
@KristofferC KristofferC mentioned this pull request Dec 2, 2021
15 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Dec 11, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
vchuravy pushed a commit to JuliaLang/Test.jl that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Julia's standard library testsystem The unit testing framework and Test stdlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants