-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing.md updated #42500
Missing.md updated #42500
Conversation
Update first three sections.
Updated 2 more paras
Welcome to Julia and thanks for a nice first contribution! The removal of most of the line breaks makes it a little bit hard to see from the diff what the change are. Note also the failed whitespace CI: https://buildkite.com/julialang/julia-master/builds/4358#46bbefc3-53c5-4e39-b60e-a52129586aad
|
Oh I didn't remove any of the line breaks, just made it so things aren't squashed onto one side of the screen. Lots of updates, typos, and grammar fixes, but I'll fix the failed whitespace. |
I guess that is what I meant with
|
Ahh right. All good. Did you figure out what broke @KristofferC ? I couldn't find any differences in the lines that threw the errors. |
Would it be safe to merge this since tests are passing on linux64? |
Co-authored-by: woclass <git@wo-class.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
which implies that we do not know how the program should behave. A [`TypeError`](@ref) | ||
is thrown as soon as a `missing` value is encountered in this context | ||
Control flow operators including [`if`](@ref), [`while`](@ref) and the [ternary operator](@ref man-conditional-evaluation) `x ? y : z` do not allow for missing values. This is because of the uncertainty about whether the actual value would be `true` or `false` if we could observe it. This implies we do not know how the program should behave. Thus, a [`TypeError`](@ref) is thrown as soon as a `missing` value is encountered in this context: | ||
|
||
```jldoctest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where the error is and there's no change from the original. Not sure why it's failing @KristofferC
which implies that we do not know how the program should behave. A [`TypeError`](@ref) | ||
is thrown as soon as a `missing` value is encountered in this context | ||
Control flow operators including [`if`](@ref), [`while`](@ref) and the [ternary operator](@ref man-conditional-evaluation) `x ? y : z` do not allow for missing values. This is because of the uncertainty about whether the actual value would be `true` or `false` if we could observe it. This implies we do not know how the program should behave. Thus, a [`TypeError`](@ref) is thrown as soon as a `missing` value is encountered in this context: | ||
|
||
```jldoctest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically these lines @KristofferC . Thoughts?
@KristofferC let me know if there's anything else I need to do to help get this merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now after the fixups by @fredrikekre. (If you look at the diff now vs the one before you can see how much easier it is to review now).
Typo fixes, paragraph fixes, grammar usage, and "massage" of text.
Hopefully that makes it much easier to read and understand 😄