-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base.julia_cmd()
: correctly forward the --sysimage-native-code=no
flag if it is provided
#42185
Conversation
… flag if it is provided
@vtjnash @staticfloat We don't need to backport this, right? Since the motivation here is to fix the code coverage, and we only run code coverage on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, it was even already documented
Or do we need to backport this because it is a bug fix? Since it was in the docstring. |
I'm going to mark this for backport as a bugfix. If that is not correct, please remove the backport labels. |
@staticfloat @vtjnash This PR seems to have broken the coverage job. See e.g. https://buildkite.com/julialang/julia-master-scheduled/builds/225
|
I'm removing the backport labels until we can figure out why this broke the code coverage Buildkite job. |
looks like buildkite needs to increase the timeout threshold for starting workers, as we launch a lot of them, and these are probably noisy machines |
Note that it is a 32-core machine, and it looks like buildkite is mis-configured to force the launching of 16*16 (or 256) threads |
We could increase the timeout. That being said, before this PR was merged, the code coverage Buildkite job had no trouble starting all of its workers within the default timeout. See e.g. the following successful jobs:
Is it possible that this PR specifically would increase the time it takes a worker to start up? |
To increase the timeout, I'm assuming I just need to set the |
Yes, but also, we need to fix that configuration bug too |
Ah, the 16 workers * 16 threads per worker? For that one, I think we can just set |
Increasing the worker timeout seems to have resolved the issue with the code coverage job, so I'm adding the backport labels back. |
… flag if it is provided (JuliaLang#42185)
… flag if it is provided (JuliaLang#42185)
Closes #42173
Ref #41238 (comment)
This is a replacement for #42173.