Relax stride(A,2) requirements in BLAS.gemv!
#42012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sostock
added
linear algebra
|
Who would be good to review this? |
|
I just uploaded #42054 as a replacement for this PR. It is less restrictive regarding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the regression noted in #41513 (comment). All cases that worked correctly before #41513 should now work again.
There is still a case that could be made to work, but errors. I didn’t change it because it also errored before #41513: the case of a matrix
Awithstride(A,1) < 1 && (size(A,1) <= 1 || size(A,2) == 0).