Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade libuv to v2-1.42.0 #41710

Merged
merged 1 commit into from
Jul 28, 2021
Merged

upgrade libuv to v2-1.42.0 #41710

merged 1 commit into from
Jul 28, 2021

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jul 26, 2021

Testing how this does across platforms, before doing the Yggdrasil build.

most of our old patches applied directly with some removals (and there is a couple more that I just started work on backporting now):

@vtjnash vtjnash added io Involving the I/O subsystem: libuv, read, write, etc. backport 1.7 labels Jul 26, 2021
@ararslan ararslan added the external dependencies Involves LLVM, OpenBLAS, or other linked libraries label Jul 26, 2021
@vtjnash vtjnash changed the title [WIP] upgrade libuv to v2-1.42.0 upgrade libuv to v2-1.42.0 Jul 28, 2021
@vtjnash vtjnash merged commit b50bf04 into master Jul 28, 2021
@vtjnash vtjnash deleted the jn/uv2-1.42.0 branch July 28, 2021 17:48
KristofferC pushed a commit that referenced this pull request Aug 2, 2021
@vtjnash @KristofferC
upgrade libuv to v2-1.42.0 (#41710)
be3e807 
(cherry picked from commit b50bf04)
@KristofferC KristofferC mentioned this pull request Aug 2, 2021
Merged
82 tasks
@DilumAluthge
Copy link
Member

DilumAluthge commented Aug 6, 2021 •
edited
Loading

@vtjnash @ararslan I think this PR might be what broke the build on FreeBSD 11.

@ararslan
Copy link
Member

ararslan commented Aug 6, 2021 •
edited
Loading

Yeah the package_freebsd job failed on CI. Probably shouldn't have been merged without green across the board.

@DilumAluthge
Copy link
Member

DilumAluthge commented Aug 6, 2021 •
edited
Loading

The following builds were performed in a virtual machine with FreeBSD 11.4 on x86_64.

  • ✅ = Julia builds successfully.
  • ❌ = Julia fails to build.

I did not run the test suite. This table only indicates whether or not I was able to build Julia.

Commit Julia build
1c951f7 ✅
b50bf04 ❌
cb30aa7 (current master) ❌
cb30aa7 (current master) plus revert b50bf04 ✅

DilumAluthge added a commit that referenced this pull request Aug 6, 2021
@DilumAluthge
Revert "upgrade libuv to v2-1.42.0 (#41710)"
2574460 
This reverts commit b50bf04.
@DilumAluthge DilumAluthge mentioned this pull request Aug 6, 2021
Closed
DilumAluthge added a commit that referenced this pull request Aug 7, 2021
@DilumAluthge
Revert "upgrade libuv to v2-1.42.0 (#41710)"
7244006 
This reverts commit b50bf04.
DilumAluthge added a commit that referenced this pull request Aug 7, 2021
@DilumAluthge
Revert "upgrade libuv to v2-1.42.0 (#41710)"
db763ab 
This reverts commit b50bf04.
DilumAluthge added a commit that referenced this pull request Aug 11, 2021
@DilumAluthge
Revert "upgrade libuv to v2-1.42.0 (#41710)"
f10e96c 
This reverts commit b50bf04.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtjnash @DilumAluthge @ararslan @KristofferC