Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM] Add missing GPU related patch #41651

Merged
merged 1 commit into from
Jul 20, 2021
Merged

[LLVM] Add missing GPU related patch #41651

merged 1 commit into from
Jul 20, 2021

Conversation

vchuravy
Copy link
Member

No description provided.

@vchuravy vchuravy added this to the 1.7 milestone Jul 20, 2021
@vchuravy vchuravy added backport 1.7 gpu Affects running Julia on a GPU upstream The issue is with an upstream dependency, e.g. LLVM labels Jul 20, 2021
@vchuravy vchuravy requested a review from maleadt July 20, 2021 12:01
@vchuravy
Copy link
Member Author

Already part of Yggdrasil for both 12.0.0 and 12.0.1 https://github.com/JuliaPackaging/Yggdrasil/blob/master/L/LLVM/LLVM_full%4012.0.1/bundled/llvm_patches/0060-llvm-invalid-addrspacecast-sink.patch

@vchuravy vchuravy added the merge me PR is reviewed. Merge when all tests are passing label Jul 20, 2021
Sacha0
Sacha0 approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficially LGTM. Thanks Valentin! :)

@vchuravy vchuravy marked this pull request as ready for review July 20, 2021 15:09
@vchuravy vchuravy merged commit 52cb3c0 into master Jul 20, 2021
@vchuravy vchuravy deleted the vc/gpu_patch branch July 20, 2021 15:09
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jul 22, 2021
@KristofferC KristofferC mentioned this pull request Jul 26, 2021
Merged
82 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

@maleadt maleadt Awaiting requested review from maleadt

Assignees
No one assigned
Labels
gpu Affects running Julia on a GPU upstream The issue is with an upstream dependency, e.g. LLVM
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@vchuravy @Sacha0 @KristofferC @DilumAluthge