Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #41157, unnecessary assertion on Tuple{Union{}} #41483

Merged
merged 1 commit into from
Jul 6, 2021
Merged

fix #41157, unnecessary assertion on Tuple{Union{}} #41483

merged 1 commit into from
Jul 6, 2021

Conversation

JeffBezanson
Copy link
Member

fix #41157

@JeffBezanson JeffBezanson added compiler:codegen Generation of LLVM IR and native code bugfix This change fixes an existing bug backport 1.7 labels Jul 6, 2021
Sacha0
Sacha0 approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a tough review, but I eventually made it through.

@JeffBezanson JeffBezanson merged commit 4733c00 into master Jul 6, 2021
@JeffBezanson JeffBezanson deleted the jb/fix41157 branch July 6, 2021 21:41
KristofferC pushed a commit that referenced this pull request Jul 7, 2021
@JeffBezanson @KristofferC
fix #41157, unnecessary assertion on Tuple{Union{}} (#41483)
35c5fc1 
(cherry picked from commit 4733c00)
@KristofferC KristofferC mentioned this pull request Jul 7, 2021
Merged
82 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unhappy codegen handling of invalid tuples
4 participants
@JeffBezanson @vtjnash @Sacha0 @KristofferC