Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded Vector field for SVD #41193

Closed
wants to merge 2 commits into from
Closed

Remove hard-coded Vector field for SVD #41193

wants to merge 2 commits into from

Conversation

theogf
Copy link

@theogf theogf commented Jun 11, 2021

This aims at fixing #35716 by allowing other types than Vector for the diagonal term of SVD

@theogf theogf changed the title Remove hard-coded vector for SVD Remove hard-coded Vector field for SVD Jun 11, 2021
@dkarrasch dkarrasch added the linear algebra Linear algebra label Jun 12, 2021
@ViralBShah
Copy link
Member

ViralBShah commented Aug 15, 2021 •
edited
Loading

The V seems a bit overused here. Perhaps we can use a slightly more informative name - and then merge this.

@theogf
Copy link
Author

theogf commented Aug 18, 2021

How about Tdiag ?

@ViralBShah
Copy link
Member

Could you add a test, and also rebase to master?

@dkarrasch
Copy link
Member

Seems like this gets fixed by #42594 along the way?

@theogf theogf closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theogf @ViralBShah @dkarrasch