-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Relax eltype condition in rdiv!
with Diagonal
#40942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rdiv!
with Diagonal
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
Maybe this is an opportunity to remove even more of the same-eltype conditions related to |
I deleted the main repository for this PR since you had reviewed and approved the changes (mainly because it was made from master and not a sub-branch). I can open another PR to implement what you suggested. |
Sounds good. |
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
Closes JuliaLang/LinearAlgebra.jl#849.
Before
julia> rdiv!(ones(2,2), 3I(2)) ERROR: MethodError: no method matching rdiv!(::Matrix{Float64}, ::Diagonal{Int64, Vector{Int64}})
After
julia> rdiv!(ones(2,2), 3I(2)) 2×2 Matrix{Float64}: 0.333333 0.333333 0.333333 0.333333