Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace broken replaceuserpath function with existing contractuser one #40274

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Mar 31, 2021

Fixes #39674

@vtjnash vtjnash added the backport 1.6 Change should be backported to release-1.6 label Mar 31, 2021
@@ -698,7 +691,7 @@ end
function print_stackframe(io, i, frame::StackFrame, n::Int, digit_align_width, modulecolor)
file, line = string(frame.file), frame.line
stacktrace_expand_basepaths() && (file = something(find_source_file(file), file))
stacktrace_contract_userdir() && (file = replaceuserpath(file))
stacktrace_contract_userdir() && (file = contractuser(file))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to work on Windows (which might be why the custom function was called).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is exactly the wrong reason to define a new function however

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open a new issue to change that function? It is okay to assign me.

@vtjnash vtjnash merged commit d07b5a1 into master Apr 2, 2021
@vtjnash vtjnash deleted the jn/39674 branch April 2, 2021 03:24
KristofferC pushed a commit that referenced this pull request Apr 4, 2021
@KristofferC KristofferC mentioned this pull request Apr 4, 2021
33 tasks
KristofferC pushed a commit that referenced this pull request Apr 4, 2021
KristofferC pushed a commit that referenced this pull request Apr 4, 2021
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 4, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in user path replacement in stacktrace
2 participants