Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow kwarg in function composition #39147

Merged
merged 4 commits into from
Feb 25, 2021

Conversation

alecloudenback
Copy link
Contributor

@alecloudenback alecloudenback commented Jan 8, 2021

closes #38351

This pull request would allow kwargs in functions that are composed with (a ComposedFunction). This is my first commit to Julia base.

The compat note in the docstring assumes that this change would make it into 1.7.

Needs:

  • test case
  • docstring update

@alecloudenback alecloudenback marked this pull request as ready for review January 9, 2021 04:01
Copy link
Contributor

@jw3126 jw3126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jw3126
Copy link
Contributor

jw3126 commented Jan 15, 2021

Bump! Can this be merged?

@jw3126
Copy link
Contributor

jw3126 commented Jan 31, 2021

bump

@logankilpatrick logankilpatrick added triage This should be discussed on a triage call keyword arguments f(x; keyword=arguments) labels Feb 11, 2021
@JeffBezanson JeffBezanson merged commit a3eda19 into JuliaLang:master Feb 25, 2021
@JeffBezanson JeffBezanson removed the triage This should be discussed on a triage call label Feb 25, 2021
@JeffBezanson
Copy link
Member

Thanks! Congrats on your first julia base PR.

ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@alecloudenback
Copy link
Contributor Author

alecloudenback commented May 18, 2021

Is this worth including in NEWS.md? @JeffBezanson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyword arguments f(x; keyword=arguments)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow usage with kwargs
4 participants