Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Eigen to keep additional information from geevx #38483

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Extend Eigen to keep additional information from geevx #38483

merged 1 commit into from
Apr 16, 2021

Conversation

KlausC
Copy link
Contributor

@KlausC KlausC commented Nov 18, 2020

includes proposal for #38335

Allows to opt in evaluation of left eigenvectors and condition numbers in eigen decomposition eigen.
Uses additional flag unitary to support spectral operations with the decomposition.
See discussion #38335

@dkarrasch dkarrasch added the linear algebra Linear algebra label Nov 19, 2020
@KlausC KlausC closed this Dec 9, 2020
@KlausC KlausC reopened this Dec 9, 2020
@stevengj
Copy link
Member

stevengj commented Mar 2, 2021

(Closes #13307.)

@vtjnash vtjnash closed this Apr 3, 2021
@vtjnash vtjnash reopened this Apr 3, 2021
@vtjnash
Copy link
Member

vtjnash commented Apr 3, 2021

LGTM. Can you fix the doctest?

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Apr 16, 2021
@vtjnash vtjnash merged commit 9d3a7c4 into JuliaLang:master Apr 16, 2021
@simeonschaub simeonschaub removed the merge me PR is reviewed. Merge when all tests are passing label Apr 28, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@KlausC @ElOceanografo
Extend Eigen to keep additional information from geevx (JuliaLang…
f73f740 
…#38483)

Closes JuliaLang#13307
Fixes JuliaLang#38335
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@KlausC @antoine-levitt
Extend Eigen to keep additional information from geevx (JuliaLang…
f252987 
…#38483)

Closes JuliaLang#13307
Fixes JuliaLang#38335
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@KlausC @johanmon
Extend Eigen to keep additional information from geevx (JuliaLang…
949a294 
…#38483)

Closes JuliaLang#13307
Fixes JuliaLang#38335
@pgunnink
Copy link

pgunnink commented Jul 7, 2021

I just came across this PR (Google is magic sometimes) and it is probably useful to mention in the Docs somewhere how the left eigenvectors returned this way are defined. I have only confirmed this numerically, but it is probably the same as in Numpy, i.e. for the matrix H the left eigenvectors satisfyL' H == E L', see also this discussion. So the conventional definition, such as in https://mathworld.wolfram.com/LeftEigenvector.html, does not hold.

@RalphAS RalphAS mentioned this pull request Jul 13, 2021
Open
andreasnoack added a commit that referenced this pull request Jul 14, 2021
@andreasnoack
Revert "Extend Eigen to keep additional information from geevx (#…
5f97b12 
…38483)"

This reverts commit 9d3a7c4.
@andreasnoack andreasnoack mentioned this pull request Jul 14, 2021
Merged
DilumAluthge pushed a commit that referenced this pull request Jul 15, 2021
@andreasnoack
Revert "Extend Eigen to keep additional information from geevx (#… (
41ee0fa 
#41578)

* Revert "Extend `Eigen` to keep additional information from `geevx` (#38483)"

This reverts commit 9d3a7c4.

* Remove left eigenvector handling in Float16 eigen methods.
andreasnoack added a commit that referenced this pull request Jul 19, 2021
@andreasnoack
Revert "Extend Eigen to keep additional information from geevx (#…
8d7a4ae 
…38483)"

This reverts commit 9d3a7c4.
KristofferC pushed a commit that referenced this pull request Jul 20, 2021
@andreasnoack @KristofferC
Revert "Extend Eigen to keep additional information from geevx (#…
31aad85 
…38483)"

This reverts commit 9d3a7c4.
@RalphAS RalphAS mentioned this pull request Aug 9, 2021
Open
@KlausC KlausC mentioned this pull request Feb 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KlausC @stevengj @vtjnash @pgunnink @simeonschaub @dkarrasch