Extend Eigen to keep additional information from geevx
#38483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Closes JuliaLang/LinearAlgebra.jl#261.) |
|
LGTM. Can you fix the doctest? |
simeonschaub
removed
the
merge me
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…#38483) Closes #13307 Fixes #38335
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…#38483) Closes #13307 Fixes #38335
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…#38483) Closes #13307 Fixes #38335
|
I just came across this PR (Google is magic sometimes) and it is probably useful to mention in the Docs somewhere how the left eigenvectors returned this way are defined. I have only confirmed this numerically, but it is probably the same as in Numpy, i.e. for the matrix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes proposal for JuliaLang/LinearAlgebra.jl#779
Allows to opt in evaluation of left eigenvectors and condition numbers in eigen decomposition
eigen.Uses additional flag
unitaryto support spectral operations with the decomposition.See discussion JuliaLang/LinearAlgebra.jl#779