[Darwin/AArch64] Force BB triplet for now #38421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toolchain we're using in BB is experimental. Since there is no official GCC toolchain (yet), we can't expect ABI compatibility, so just ignore whatever fortran may or may not be installed on the host and hardcode the triplet we expect.
staticfloat
approved these changes
Nov 13, 2020
staticfloat
reviewed
Nov 13, 2020
| @@ -1499,8 +1499,12 @@ LIBGCC_NAME := libgcc_s_seh-1.$(SHLIB_EXT) | |||
| endif | |||
| endif | |||
| ifeq ($(OS),Darwin) | |||
| ifeq ($(ARCH),aarch64) | |||
| LIBGCC_NAME := libgcc_s.2.$(SHLIB_EXT) | |||
There was a problem hiding this comment.
It's not clear to me whether this libgcc name is a temporary thing from iain's branch or permanent.
There was a problem hiding this comment.
Not clear to me either, but since we're hardcoding the toolchain for now, I think it's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolchain we're using in BB is experimental. Since there is no official
GCC toolchain (yet), we can't expect ABI compatibility, so just ignore whatever
fortran may or may not be installed on the host and hardcode the triplet
we expect.