Backport prepare_for_deletion()
#38159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I meant just backporting in Pkg, but maybe it is generally useful. |
fredrikekre
approved these changes
Oct 23, 2020
Sacha0
force-pushed
the
backports-release-1.5
branch
from
a408c1d to
bb83a29
Compare
ararslan
reviewed
Oct 27, 2020
| weird permissions a user may have created directories with within the temporary prefix, | ||
| it will always be deleted. | ||
| """ | ||
| function prepare_for_deletion(path::AbstractString) |
There was a problem hiding this comment.
This seems like backporting a feature......
There was a problem hiding this comment.
I'd argue it's closer to a bugfix for mktempdir(). :P
staticfloat
force-pushed
the
sf/backport_prepare_for_deletion
branch
from
49b8624 to
bca2df2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports a3430e7 to Julia 1.5.3
X-ref: JuliaLang/Pkg.jl#2162