Fix some arithmetic invalidations #37820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doctest failure looks related. Will investigate. Stacktrace: ERROR: LoadError: TypeError: in typeassert, expected UInt64, got a value of type Int64
Stacktrace:
[1] writeshortest(buf::Vector{UInt8}, pos::Int64, x::Float64, plus::Bool, space::Bool, hash::Bool, precision::Int64, expchar::UInt8, padexp::Bool, decchar::UInt8, typed::Bool, compact::Bool)
@ Base.Ryu ./ryu/shortest.jl:387
[2] show(io::IOContext{IOBuffer}, x::Float64, forceuntyped::Bool, fromprint::Bool)
@ Base.Ryu ./ryu/Ryu.jl:115
[3] show(io::IOContext{IOBuffer}, x::Float64)
... |
KristofferC
reviewed
Sep 30, 2020
KristofferC
reviewed
Sep 30, 2020
base/strings/string.jl
Outdated
| @@ -92,7 +92,7 @@ String(s::CodeUnits{UInt8,String}) = s.s | |||
| ## low-level functions ## | |||
|
|
|||
| pointer(s::String) = unsafe_convert(Ptr{UInt8}, s) | |||
| pointer(s::String, i::Integer) = pointer(s)+(i-1) | |||
| pointer(s::String, i::Integer) = pointer(s) + (i - 1)::Integer | |||
There was a problem hiding this comment.
Sometimes these are written as Int(i)::Int - 1.
There was a problem hiding this comment.
Is there any concern about having values too large to convert to an Int? It seems unlikely that would occur but I figured I'd ask
There was a problem hiding this comment.
I'd think string length is pretty safe; someone would need to have a single string that's more than half the size of memory on a 32-bit machine. I guess you could alternatively use UInt.
omus
force-pushed
the
cv/arithmetic-latency
branch
from
72ebdec
to
a0f4c34
Compare
|
I think there is nothing left to do here. I'll wait to merge until I get approval |
timholy
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating invenia/Intervals.jl#144 I noticed these invalidations:
The use of
Anystuck out to me so I looked into these and the changes PR was is the result. With these changes this invalidations no longer exist. Please let me know if I'm off base here as I am new to addressing invalidations.