fix type inference regression in Ryu #37802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #37163, a performance regression snuck in, likely due to a misunderstanding in that this array is not only used during compilation time but also at runtime. Making it
Any
is therefore detrimental for performance. This restores things while also avoiding the interpolation of the array into the AST because it makes e.g.@code_warntype
annoying to read. Also, make the array into a tuple because that tends to codegen slightly better.Before:
after