pty_{master,slave} -> pt{m,s} #36315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We decided to get rid of the master/slave terminology in Julia in #30058. However, we decided to keep it for PTYs, where the terminology is imposed upon us by POSIX (and thus changing it would be confusing for people who might need to read up on the POSIX definitions of these concepts). It was recently suggested to revisit this, by renaming to ptm and pts instead, which also fit well (as the devies that the fds refer to are `/dev/ptmx` and `/dev/pts` respectively), are googleable (`pty pts` will yield the correct man page) and will probably need to remain even if POSIX adjusts their terminology, since they're part of the ABI (presumably they'll be backronymed to whatever terminology ends up winning). This patch does this rename.
JeffBezanson
approved these changes
Jun 16, 2020
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
We decided to get rid of the master/slave terminology in Julia in JuliaLang#30058. However, we decided to keep it for PTYs, where the terminology is imposed upon us by POSIX (and thus changing it would be confusing for people who might need to read up on the POSIX definitions of these concepts). It was recently suggested to revisit this, by renaming to ptm and pts instead, which also fit well (as the devies that the fds refer to are `/dev/ptmx` and `/dev/pts` respectively), are googleable (`pty pts` will yield the correct man page) and will probably need to remain even if POSIX adjusts their terminology, since they're part of the ABI (presumably they'll be backronymed to whatever terminology ends up winning). This patch does this rename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to get rid of the master/slave terminology in Julia in #30058.
However, we decided to keep it for PTYs, where the terminology is imposed
upon us by POSIX (and thus changing it would be confusing for people who
might need to read up on the POSIX definitions of these concepts). It
was recently suggested to revisit this, by renaming to ptm and pts instead,
which also fit well (as the devies that the fds refer to are
/dev/ptmxand
/dev/ptsrespectively), are googleable (pty ptswill yield thecorrect man page) and will probably need to remain even if POSIX
adjusts their terminology, since they're part of the ABI (presumably
they'll be backronymed to whatever terminology ends up winning).
This patch does this rename.