-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #34316 #34817
Merged
Merged
Fix #34316 #34817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return Inf if either input is Inf
Create a testset for hypot and add tests in the unitless case.
KristofferC
reviewed
Feb 19, 2020
Adapt code to work without promotion rules and remoeve float specific behavior
Thanks for the review. I added the suggested changes in the latest commit. |
KristofferC
pushed a commit
that referenced
this pull request
Feb 21, 2020
26 tasks
birm
pushed a commit
to birm/julia
that referenced
this pull request
Feb 22, 2020
Fix hypot with both arguments 0 Remove hypot from Furlongs in order to test the defined fallback
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
BioTurboNick
pushed a commit
to BioTurboNick/julia
that referenced
this pull request
Apr 13, 2020
Fix hypot with both arguments 0 Remove hypot from Furlongs in order to test the defined fallback (cherry picked from commit 8e3aa66)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The differences between the proposed solution in #34771 (comment) are
oneunit
instead ofone
(seeone
andzero
inconsistency PainterQubits/Unitful.jl#291)isinf
in order to have a similar behavior with the unitless case. Should this be done more generally with something like the following?hypot
definition fromFurlongs
. I looked at why the tests were passing with the previous definition ofhypot
and I discovered that the fallback was not actually tested because of the additional method.