Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a test for something that used to break the optimizer #33566

Merged
merged 1 commit into from
Oct 15, 2019
Merged

add a test for something that used to break the optimizer #33566

merged 1 commit into from
Oct 15, 2019

Conversation

KristofferC
Copy link
Member

Closes #30093

@kshyatt kshyatt added the test This change adds or pertains to unit tests label Oct 15, 2019
vtjnash
vtjnash approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently mitigated by #28878, so good to have this test to catch if something causes it to regress

@StefanKarpinski StefanKarpinski merged commit 3a20608 into master Oct 15, 2019
@StefanKarpinski StefanKarpinski deleted the kc/opt_test branch October 15, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal Error: BoundsError
4 participants
@KristofferC @vtjnash @StefanKarpinski @kshyatt