rework basename (fixes #33000) #33021
Conversation
base/path.jl
Outdated
| elseif path == "/" | ||
| return "/" | ||
| elseif path == "~" | ||
| return basename(ENV["HOME"]) |
There was a problem hiding this comment.
POSIX basename() doesn't do ~ expansion and I don't think ENV["HOME"] will work on Windows. I don't think ~ expansion should be done here.
There was a problem hiding this comment.
Not to mention ~ is a valid filename...
There was a problem hiding this comment.
Thanks for the review, I'm really not very familiar with these rules.
I add this because I checked the basename ~ in Linux and macOS, both returns jc in my case. And basename ~/~ returns ~
There was a problem hiding this comment.
When running basename from the command line it is the shell that is doing the ~ expansion, not the basename utility. Try basename '~'.
|
On Windows this will need to work with |
|
I think this works for Windows now, but I don't have access to a Windows computer these days. As @musm says, this is a breaking change. I need to get more feedback from others to see if this worth continuing. |
|
closed by #37580 |
fixes #33000
The current implementation of
basenameisn't consistent to POSIX basenamecc: @rfourquet @sjoelund