Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix -Symmetric for Bool or JuMP.VariableRef #32375

Merged
merged 5 commits into from
Jun 26, 2019
Merged

Fix -Symmetric for Bool or JuMP.VariableRef #32375

merged 5 commits into from
Jun 26, 2019

Conversation

blegat
Copy link
Contributor

@blegat blegat commented Jun 20, 2019

Closes #32374

@mlubin mlubin mentioned this pull request Jun 20, 2019
Merged
@fredrikekre fredrikekre added the linear algebra Linear algebra label Jun 24, 2019
fredrikekre
fredrikekre reviewed Jun 25, 2019
View reviewed changes
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put back the test for Hermitian too.

stdlib/LinearAlgebra/test/symmetric.jl Outdated Show resolved Hide resolved
stdlib/LinearAlgebra/test/symmetric.jl Outdated Show resolved Hide resolved
@fredrikekre fredrikekre merged commit d958419 into JuliaLang:master Jun 26, 2019
KristofferC pushed a commit that referenced this pull request Jul 1, 2019
@blegat @KristofferC
Fix element type of -Symmetric(A) for e.g. Bool or JuMP.VariableRef, f…
3546c63 
…ixes #32374 (#32375)

(cherry picked from commit d958419)
@KristofferC KristofferC mentioned this pull request Jul 1, 2019
Merged
32 tasks
KristofferC pushed a commit that referenced this pull request Aug 26, 2019
@blegat @KristofferC
Fix element type of -Symmetric(A) for e.g. Bool or JuMP.VariableRef, f…
491c498 
…ixes #32374 (#32375)

(cherry picked from commit d958419)
@KristofferC KristofferC mentioned this pull request Aug 26, 2019
Merged
55 tasks
KristofferC pushed a commit that referenced this pull request Aug 26, 2019
@blegat @KristofferC
Fix element type of -Symmetric(A) for e.g. Bool or JuMP.VariableRef, f…
60b1fea 
…ixes #32374 (#32375)

(cherry picked from commit d958419)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@blegat @KristofferC
Fix element type of -Symmetric(A) for e.g. Bool or JuMP.VariableRef, f…
9ef82d0 
…ixes #32374 (#32375)

(cherry picked from commit d958419)
@blegat blegat mentioned this pull request May 5, 2020
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eltype of -Symmetric(Q)
3 participants
@blegat @fredrikekre @KristofferC