[release-1.0] another improvement to closure analysis precision #32248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
compiler:lowering
|
Yes please! This is more than a "performance bug". It also fixes a bad memory explosion, which is much more significant than just poor performance. |
|
Moved to #32263 where it will hopefully have a chance of getting more green check marks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #30972 to 1.0. I've received requests to backport this, since it makes a very big dent in closure performance problems (#15276). It's especially important for
@threads, which introduces a non-obvious closure that can totally tank performance --- easily orders of magnitude. In those cases it's basically a "performance bug".This code has been in use for 4 months and seems to be very solid. It has not needed any fixes in that time.