Unconditionally append lib/julia to rpath, fixes #31903. #31933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
added
the
building
staticfloat
requested changes
May 6, 2019
Member
staticfloat
left a comment
staticfloat
left a comment
There was a problem hiding this comment.
While not strictly necessary on all platforms (it seems only necessary on FreeBSD and musl) this doesn't hurt, so IMO it's a good idea to be as consistent as possible across platforms.
One minor change: instead of adding it on to RPATH, just set RPATH completely.
staticfloat
approved these changes
May 6, 2019
KristofferC
pushed a commit
that referenced
this pull request
Jul 8, 2019
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
55 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.