Refactor Inlining. NFC. #31306
Merged
Refactor Inlining. NFC. #31306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
force-pushed
the
kf/refactorinlining
branch
2 times, most recently
from
895daef to
849a371
Compare
|
Note: better viewed with ignore whitespace turned on. |
vtjnash
reviewed
Mar 11, 2019
base/compiler/ssair/inlining.jl
Outdated
| f = isdefined(ft, :instance) ? ft.instance : nothing | ||
| return svec(f, ft, atypes, argexprs, invoke_data) | ||
| f = singleton_type(ft) | ||
| return svec(Signature(f, ft, atypes), invoke_data) |
| if late_inline_special_case!(ir, sig, idx, stmt) || is_return_type(sig.f) | ||
| return nothing | ||
| end | ||
| return (sig, invoke_data) |
There was a problem hiding this comment.
This is the same signature as the other one above. I'll just leave it as a tuple.
I'm working on some problems that require some slightly different characteristics than our default inliner. While working on that, I got frustrated by some of the accumulated cruft and structuring of the inliner, so I decided to spend some time to clean it. This doesn't change any behavior, but moves some of the code around, drops now-unused arguments and properties and introduces a `Signature` struct to encapsulate the (f, ft, atypes, atype) tuple we passed around everywhere.
Keno
force-pushed
the
kf/refactorinlining
branch
from
849a371 to
cfb4dfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on some problems that require some slightly different
characteristics than our default inliner. While working on that,
I got frustrated by some of the accumulated cruft and structuring
of the inliner, so I decided to spend some time to clean it. This
doesn't change any behavior, but moves some of the code around,
drops now-unused arguments and properties and introduces a
Signaturestruct to encapsulate the (f, ft, atypes, atype) tuple we passed around
everywhere.