Skip to content

avoid assertion due to overflow if Num is negative #31099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2019
Merged

avoid assertion due to overflow if Num is negative #31099

merged 1 commit into from
Feb 18, 2019

Conversation

vchuravy
Copy link
Member

Fixes #30621

This fixes the symptom, Num is -2 at this place which we then take to be unsigned.
@Keno is -2 a valid value here?

@vchuravy vchuravy requested a review from Keno February 18, 2019 04:19
@Keno
Copy link
Member

Keno commented Feb 18, 2019

Yes, negative numbers indicate values that don't need to be rooted for various reasons

@vchuravy vchuravy added triage This should be discussed on a triage call backport 1.0 labels Feb 18, 2019
@vchuravy vchuravy merged commit e5e1253 into master Feb 18, 2019
@vchuravy vchuravy deleted the vc/late-gc-overflow branch February 18, 2019 13:52
@KristofferC KristofferC removed the triage This should be discussed on a triage call label Aug 26, 2019
@KristofferC KristofferC mentioned this pull request Aug 26, 2019
Merged
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Late GC lowering pass crashes due to trying to alloc bitvector with 0xffffffff elements
3 participants
@vchuravy @Keno @KristofferC