-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
worklist changes for partr (1/3) #30806
Conversation
while head_next !== val | ||
head = head_next | ||
head_next = head.next | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if head_next === nothing
... ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first line of this function should guarantee that val
is found.
So this is basically moving task-related code from |
Part 2 merged into this branch. |
baf0caa
to
bd610a3
Compare
This PR attempts to implement most of the representation changes in kp/partr, while avoiding actually bringing in the multiq code (yet). These changes are actually mostly independent of that change (e.g we could instead adapt that PR to use arrays, then decide whether to make this change later; or we could chose to do this PR, then never merge partr). But these changes that are being proposed over there seem sensible to me as a stepping stone.
TODO:
list_deletefirst!