build: improve special environment variable handling #30722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, it's failing on FreeBSD because we've been mis-linking the binary (e.g. https://build.julialang.org/#/builders/68/builds/2203/steps/6/logs/stdio). Well, at least that detection was the explicit goal of making this change 😜 |
The application of JLDFLAGS was missing on many libraries, and clean up some of this code to avoid needing `override`. Also add -Wl,-no-undefined on platforms where it is supported (FreeBSD has problems with it) and not already the default (on Apple and Win32).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application of JLDFLAGS was missing on many libraries, and clean up some of this code to avoid needing
override. Also add-Wl,-no-undefinedon platforms where it is not already the default.