Improve REPL completions #30569
Merged
Improve REPL completions #30569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
backport pending 1.0
REPL
stdlib/REPL/src/REPLCompletions.jl
Outdated
| funargs = ex_org.args[2:end] | ||
| # handle broadcasting | ||
| if ex_org.head === :. && ex_org.args[2] isa Expr | ||
| funargs = ex_org.args[2].args |
There was a problem hiding this comment.
This doesn't seem right to me --- in f.(args the function won't necessarily be called on those arguments, but their elements (if arrays). This is a bit tricky to handle, so I'd leave it out for now.
There was a problem hiding this comment.
Doh, of course. I've pushed a commit such that we always return all methods that match the number of arguments and completely disregard any argument types.
IMHO that's better than not having any autocompletions for broadcasted functions, but lemme know if you don't think so and I'll remove that codepath :)
|
Is this good to go now or should I remove the broadcast completion part? |
StefanKarpinski
added
triage
JeffBezanson
removed
triage
|
Bump. |
|
Related to #24257 also? |
vtjnash
approved these changes
Apr 2, 2019
KristofferC
pushed a commit
that referenced
this pull request
Apr 15, 2019
* fix internal repl completion error * fix error with broadcast method completions * method completions for broadcasted functioncalls * better broadcast funcall completions (cherry picked from commit a0474d7)
KristofferC
pushed a commit
that referenced
this pull request
Apr 17, 2019
* fix internal repl completion error * fix error with broadcast method completions * method completions for broadcasted functioncalls * better broadcast funcall completions (cherry picked from commit a0474d7)
KristofferC
pushed a commit
that referenced
this pull request
Apr 20, 2019
* fix internal repl completion error * fix error with broadcast method completions * method completions for broadcasted functioncalls * better broadcast funcall completions (cherry picked from commit a0474d7)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
* fix internal repl completion error * fix error with broadcast method completions * method completions for broadcasted functioncalls * better broadcast funcall completions (cherry picked from commit a0474d7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JunoLab/Juno.jl#216. Might also help with #28931.
This probably isn't the right way to fix this, but I'm not sure where the error originates either...