Replace trivial uses of rethrow(exc) with rethrow() #29794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
Well, CI passes and I've double checked these replacements several times by eye. I'll merge this change in a couple of days if nobody objects; it's long but quite straightforward. |
|
@KristofferC I realized I've got some changes to |
Submit a PR to the Pkg repo. |
In all these cases we're merely rethrowing the existing exception, so it seems simpler and clearer just to use `rethrow()` without arguments.
c42f
force-pushed
the
cjf/rethrow-cleanup
branch
from
9dcf957
to
4f8a495
Compare
|
Thanks, I've reverted the changes in |
bors bot
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Nov 1, 2018
873: Replace trivial uses of rethrow(exc) with rethrow() r=fredrikekre a=c42f In all these cases we're merely rethrowing the existing exception, so it seems simpler and clearer just to use `rethrow()` without arguments. Companion to JuliaLang/julia#29794 Co-authored-by: Chris Foster <chris42f@gmail.com>
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
In all these cases we're merely rethrowing the existing exception, so it seems simpler and clearer just to use `rethrow()` without arguments. Previously it wasn't reliable to use `rethrow()` like this but the exception stack system from #29794 has fixed those problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all these cases we're merely rethrowing the existing exception, so it
seems simpler and clearer just to use
rethrow()without arguments.Now that #28878 is merged this should actually be reliable.