-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix perf regression from not specializing on iterate on tuples #29133
Conversation
@nanosoldier |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
This is strange—inference isn’t supposed to look at this flag. It would be helpful to understand what inlining decisions got made and why, as this might be indicating a deeper problem. |
Since 1.0.1 is imminent and this fixes a regression (just restores things back to how things where not too long ago). I'll merge this so we can get 1.0.1 out and open an issue so we can continue tracking this. |
(cherry picked from commit 2cd1bf8)
Reimplement a larger portion of the optimizations in jl_f__apply in the fallback function, so we can reduce the performance wall in more cases. General fix for #29133-like performance issues
Reimplement a larger portion of the optimizations in jl_f__apply in the fallback function, so we can reduce the performance wall in more cases. General fix for #29133-like performance issues
Reimplement a larger portion of the optimizations in jl_f__apply in the fallback function, so we can reduce the performance wall in more cases. General fix for #29133-like performance issues
(cherry picked from commit 2cd1bf8)
Fixes #28764 (comment).
cc @haampie
Before:
After: