Make hypot dimensionally aware and add tests
#27899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
approved these changes
Jul 2, 2018
fredrikekre
reviewed
Jul 2, 2018
test/math.jl
Outdated
| import Base: abs, isless, isinf, oneunit, /, * | ||
| using Test | ||
|
|
||
| struct MeterUnits{T} <: Number |
There was a problem hiding this comment.
Can https://github.com/JuliaLang/julia/blob/master/test/dimensionful.jl be used here instead?
There was a problem hiding this comment.
Huh, I didn't realize that existed. It would seem that at various places in the test suite, MeterUnits, PhysQuantity, and Furlong are defined. A separate PR could possibly consolidate all that.
I've followed what was done here to use TestHelpers in test/math.jl. I hope that's correct.
…or dimensionful number testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed
hypotcould be made more generic. Cross-ref PainterQubits/Unitful.jl#143. I added some tests in the style of those found in test/arrayops.jl.