Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camel-case iteratorsize and iteratoreltype #25402

Merged
merged 1 commit into from
Jan 7, 2018
Merged

Conversation

JeffBezanson
Copy link
Member

This matches other traits better.

This matches other traits better.
@JeffBezanson JeffBezanson added the deprecation This change introduces or involves a deprecation label Jan 5, 2018
@JeffBezanson JeffBezanson added this to the 1.0 milestone Jan 5, 2018
@ararslan
Copy link
Member

ararslan commented Jan 5, 2018

Will there be any possibility of a performance regression since the functions are no longer precompiled?

@JeffBezanson
Copy link
Member Author

We need to update the precompile files anyway (#24666).

@nalimilan
Copy link
Member

+1

While we're at it we should decide whether it's a good convention that traits start with Type as do TypeOrder, TypeArithmetic and TypeRangeStep in traits.jl. That convention isn't used anywhere else AFAIK, so the situation is inconsistent. Personally I don't really like these "Type" prefixes, as it's not clear what they mean.

@JeffBezanson
Copy link
Member Author

Those names sound backwards to me; I'd expect OrderType or OrderStyle (to go with IndexStyle). But less urgent.

@JeffBezanson JeffBezanson merged commit b96097b into master Jan 7, 2018
@JeffBezanson JeffBezanson deleted the jb/itertraitcase branch January 7, 2018 00:26
@fredrikekre fredrikekre added the needs news A NEWS entry is required for this change label Jan 11, 2018
@KristofferC KristofferC removed the needs news A NEWS entry is required for this change label Nov 13, 2018
Keno pushed a commit that referenced this pull request Jun 5, 2024
This matches other traits better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This change introduces or involves a deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants