Try to handle interrupting runtests better #25348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a test that was hanging and I did not know which one. Hitting ^C would kill everything without showing which tests failed and which tests didn't complete. My next attempt was to enable InterruptException, but that doesn't seem to play well with the Distributed stuff (a topic for another time). This works by setting STDIN to raw and monitoring it for ^C instead.
|
Any comments on #25417? |
|
Seems fine to me, but I couldn't get the signal-based version work reliably for the base tests at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a test that was hanging and I did not know which one. Hitting
^C would kill everything without showing which tests failed and which
tests didn't complete. My next attempt was to enable InterruptException,
but that doesn't seem to play well with the Distributed stuff (a topic
for another time). This works by setting STDIN to raw and monitoring it
for ^C instead.