Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove special lowering for and deprecate .' #25125

Merged
merged 5 commits into from
Dec 18, 2017
Merged

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Dec 16, 2017

This pull request is the next step towards #5332 after #24969 and #25083, completing items 8-12 in #24969's OP's task list. Specifically, this pull request:

  1. Rewrites all remaining uses of .' in base, test, and stdlib as appropriate.
  2. Removes the special lowering for .' in multiplication, left-division, and right-division expressions.
  3. Deprecates .'.

Notes:

  1. This pull request is based on transition linalg to Adjoint/Transpose externally #25083, from which the first twenty commits come. Only the last five commits belong to this pull request. I will rebase those commits out once transition linalg to Adjoint/Transpose externally #25083 merges. Rebased out.
  2. I deprecated .' in src/julia-syntax.scm. Whether that's the best way to go about this deprecation (or instead, e.g., lower .' to some, e.g., depwarn_transpose function defined in base/deprecated.jl) I do not know, and would appreciate input from someone better versed in these things than I :).
  3. I plan to write a news entry for these changes as part of a large, single news item on the A_mul_B and all that jazz #5332 (in a later pull request).

Thanks and best!

@Sacha0 Sacha0 added deprecation This change introduces or involves a deprecation linear algebra Linear algebra compiler:lowering Syntax lowering (compiler front end, 2nd stage) needs news A NEWS entry is required for this change labels Dec 16, 2017
@Sacha0 Sacha0 force-pushed the depdotap branch 2 times, most recently from e79016c to f7f7234 Compare December 16, 2017 17:47
@Sacha0
Copy link
Member Author

Sacha0 commented Dec 16, 2017

Rebased out the commits from #25083. Time for another round of CI roulette!

@Sacha0 Sacha0 changed the title [WIP] remove special lowering for and deprecate .' remove special lowering for and deprecate .' Dec 17, 2017
@Sacha0
Copy link
Member Author

Sacha0 commented Dec 17, 2017

The elusive CI straight flush! 🎉

@Sacha0
Copy link
Member Author

Sacha0 commented Dec 17, 2017

Rebased. Assuming CI approves again, I plan to merge these changes this evening PT or later. (The syntax deprecation and parser changes can be touched up in a later pull request if need be.) Best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:lowering Syntax lowering (compiler front end, 2nd stage) deprecation This change introduces or involves a deprecation linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants