-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove special lowering for and deprecate .' #25125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
added
deprecation
This change introduces or involves a deprecation
linear algebra
Linear algebra
compiler:lowering
Syntax lowering (compiler front end, 2nd stage)
needs news
A NEWS entry is required for this change
labels
Dec 16, 2017
Sacha0
force-pushed
the
depdotap
branch
2 times, most recently
from
December 16, 2017 17:47
e79016c
to
f7f7234
Compare
Rebased out the commits from #25083. Time for another round of CI roulette! |
Sacha0
changed the title
[WIP] remove special lowering for and deprecate .'
remove special lowering for and deprecate .'
Dec 17, 2017
The elusive CI straight flush! 🎉 |
Rebased. Assuming CI approves again, I plan to merge these changes this evening PT or later. (The syntax deprecation and parser changes can be touched up in a later pull request if need be.) Best! |
This was referenced Dec 17, 2017
Merged
This was referenced Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler:lowering
Syntax lowering (compiler front end, 2nd stage)
deprecation
This change introduces or involves a deprecation
linear algebra
Linear algebra
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the next step towards #5332 after #24969 and #25083, completing items 8-12 in #24969's OP's task list. Specifically, this pull request:
.'
in base, test, and stdlib as appropriate..'
in multiplication, left-division, and right-division expressions..'
.Notes:
This pull request is based on transition linalg to Adjoint/Transpose externally #25083, from which the first twenty commits come. Only the last five commits belong to this pull request. I will rebase those commits out once transition linalg to Adjoint/Transpose externally #25083 merges.Rebased out..'
insrc/julia-syntax.scm
. Whether that's the best way to go about this deprecation (or instead, e.g., lower.'
to some, e.g.,depwarn_transpose
function defined inbase/deprecated.jl
) I do not know, and would appreciate input from someone better versed in these things than I :).Thanks and best!