-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate diagm(A::SparseMatrixCSC) in favor of spdiagm(sparsevec(A)) #23341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending CI! :)
Edit: Perhaps add a NEWS.md entry?
Following the discussion in #23320 it looks like we will not get rid of julia/base/sparse/sparsematrix.jl Lines 3302 to 3336 in 1323561
for SparseVector . I will update the PR :)
|
c8e505c
to
7a11787
Compare
7a11787
to
4e7da40
Compare
Codecov Report
@@ Coverage Diff @@
## master #23341 +/- ##
=========================================
Coverage ? 54.98%
=========================================
Files ? 275
Lines ? 51145
Branches ? 0
=========================================
Hits ? 28121
Misses ? 23024
Partials ? 0 Continue to review full report at Codecov.
|
How does spdiagm compare in performance to the old specialized method? |
To be consistent with
Step 1 in #23320