Add a white list of known non-safepoint functions #22709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
approved these changes
Jul 8, 2017
Contributor
Author
|
I should add that |
yuyichao
force-pushed
the
yyc/codegen/julia/intrinsic
branch
2 times, most recently
from
005a0a2 to
a66d522
Compare
Contributor
Author
|
So it turns out that the |
yuyichao
force-pushed
the
yyc/codegen/julia/intrinsic
branch
from
a66d522 to
ad8589a
Compare
Contributor
Author
|
@nanosoldier |
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
These are functions we emit in codegen directly that are known to not contain any safepoint
yuyichao
force-pushed
the
yyc/codegen/julia/intrinsic
branch
from
ad8589a to
fc31ce5
Compare
tkelman
reviewed
Jul 8, 2017
| end | ||
| @test pointer_not_safepoint() == 3 | ||
|
|
||
| # The current memcmp threshold is 512bytes, make sure this struct has the same size on |
Contributor
There was a problem hiding this comment.
would this silently test a different codepath then if that limit were adjusted?
Contributor
Author
There was a problem hiding this comment.
No. that's what the @memcmp test below is for.
Contributor
Author
|
Travis linux 64 has a download issue. Restarted... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are functions we emit in codegen directly that are known to not contain any safepoint