deprecate srand(rng, filename::AbstractString, n=4) #21359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
force-pushed
the
rf/srand-filename
branch
from
a6ab042
to
48caedf
Compare
|
The deprecation mechanism does not work as I expect:
Help requested! |
rfourquet
force-pushed
the
rf/srand-filename
branch
from
48caedf
to
f7c40df
Compare
|
I am ok with deprecating this. |
|
I don't think we should do this right now though, we're just about ready for a release candidate. Should wait until we branch. |
JeffBezanson
added
the
deprecation
rfourquet
force-pushed
the
rf/srand-filename
branch
from
f7c40df
to
fb60449
Compare
|
I rebased because of conflicts, and introduced a new section for v0.7.0 in "NEWS.md", please tell me if this is not the way. |
tkelman
reviewed
May 3, 2017
base/deprecated.jl
Outdated
| @@ -1310,6 +1310,11 @@ end | |||
| # PR #16984 | |||
| @deprecate MersenneTwister() MersenneTwister(0) | |||
|
|
|||
| # PR #21359 | |||
There was a problem hiding this comment.
these need to be in a new 0.7 section
rfourquet
force-pushed
the
rf/srand-filename
branch
2 times, most recently
from
93e8eb1
to
dc2bab7
Compare
|
I would like to merge this in 1 or 2 days, if no objection comes. |
`srand` should accept a seed as second argument; here `filename` is only an indirect seed, preventing the use a string object as a direct seed.
rfourquet
force-pushed
the
rf/srand-filename
branch
from
dc2bab7
to
65757ba
Compare
rfourquet
added a commit
that referenced
this pull request
Sep 30, 2023
We used to be able to seed RNGs with a string, but that string was interpreted as the filename containing the seed. This was deprecated in #21359, in order to allow later using a string seed directly, which this patch does.
rfourquet
added a commit
that referenced
this pull request
Sep 30, 2023
We used to be able to seed RNGs with a string, but that string was interpreted as the filename containing the actual seed. This was deprecated in #21359, in order to later allow using a string seed directly, which this patch does.
rfourquet
added a commit
that referenced
this pull request
Oct 1, 2023
We used to be able to seed RNGs with a string, but that string was interpreted as the filename containing the actual seed. This was deprecated in #21359, in order to later allow using a string seed directly, which this patch does.
rfourquet
added a commit
that referenced
this pull request
Oct 7, 2023
We used to be able to seed RNGs with a string, but that string was interpreted as the filename containing the actual seed. This was deprecated in #21359, in order to later allow using a string seed directly, which this patch does.
rfourquet
added a commit
that referenced
this pull request
Oct 10, 2023
We used to be able to seed RNGs with a string, but that string was interpreted as the filename containing the actual seed. This was deprecated in #21359, in order to later allow using a string seed directly, which this patch does. --------- Co-authored-by: Nathan Zimmerberg <39104088+nhz2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method
is never used in practice, I guess, which probably makes its maintenance cost not worth it.
was introduced in b13d037 (cc @ViralBShah), mainly (apparently) to be able to seed from "/dev/urandom"; we now have a direct abstraction with
RandomDevice(e.g.srand(rng, rand(RandomDevice(), UInt32, 4)), whensrand(rng)is not enough).prevents the introduction of a more natural
srand(rng, seed::String).srandshould only accept a direct seed as second argument (for less confusion); herefilenameis an indirect seed, and hence requires an extra explanation in the docstring. Moreover, it would be easy to usesrandusing a file if the above method existed (e.g.srand(rng, read("/dev/urandom", UInt32, 4))but not the other way around).is not fully satisfying to use: e.g. if
nis too big for the file (a finite file, i.e. not "/dev/urandom"), an error is issued, and there is no way to tellsrandto read exactly the whole file (I agree that this argument is not strong, we could simply improve this method instead of deprecating it).If this method is nonetheless deemed to be useful enough that we want to keep its functionality, I propose to make the filename a keyword argument, allowing the introduction later of
srand(rng, seed::String).