Split TBAA for array buffers #21262
Merged
Split TBAA for array buffers #21262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
added
compiler:codegen
yuyichao
approved these changes
Apr 3, 2017
yuyichao
reviewed
Apr 3, 2017
| @@ -2827,7 +2828,8 @@ static bool emit_builtin_call(jl_cgval_t *ret, jl_value_t *f, jl_value_t **args, | |||
| *ret = ghostValue(ety); | |||
| } | |||
| else { | |||
| *ret = typed_load(emit_arrayptr(ary, args[1], ctx), idx, ety, ctx, tbaa_arraybuf); | |||
| *ret = typed_load(emit_arrayptr(ary, args[1], ctx), idx, ety, ctx, | |||
There was a problem hiding this comment.
seems that you can have a bool isboxed a few lines above for this one too.
There was a problem hiding this comment.
Just a small cleanup, will get it in separately.
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
|
Well, those performance results are moderately disappointing. I'll take a look. |
|
I'm not able to reproduce these performance regressions: |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
|
Nanosoldier results look like noise. Few of them are the same between the two runs, and one that is got faster in the second run. Merging. |
vtjnash
added a commit
that referenced
this pull request
Jun 18, 2019
This avoids a regression (correctness and performance) caused by #21262 where we were no longer able to fold away the isnull assertion if there exists an explicit isassigned check. Also upgrade many CreateInBoundsGEP calls to include the element type (NFC).
vtjnash
added a commit
that referenced
this pull request
Jun 18, 2019
This avoids a regression (correctness and performance) caused by #21262 where we were no longer able to fold away the isnull assertion in the case where the source also contains an explicit isassigned check. Also upgrade many CreateInBoundsGEP calls to include the element type (NFC).
vtjnash
added a commit
that referenced
this pull request
Jun 26, 2019
This avoids a regression (correctness and performance) caused by #21262 where we were no longer able to fold away the isnull assertion in the case where the source also contains an explicit isassigned check. Also upgrade many other CreateInBoundsGEP calls to include the element type (NFC).
KristofferC
pushed a commit
that referenced
this pull request
Jul 1, 2019
This avoids a regression (correctness and performance) caused by #21262 where we were no longer able to fold away the isnull assertion in the case where the source also contains an explicit isassigned check. Also upgrade many other CreateInBoundsGEP calls to include the element type (NFC). (cherry picked from commit a7427aa)
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
This avoids a regression (correctness and performance) caused by #21262 where we were no longer able to fold away the isnull assertion in the case where the source also contains an explicit isassigned check. Also upgrade many other CreateInBoundsGEP calls to include the element type (NFC). (cherry picked from commit a7427aa)
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
This avoids a regression (correctness and performance) caused by #21262 where we were no longer able to fold away the isnull assertion in the case where the source also contains an explicit isassigned check. Also upgrade many other CreateInBoundsGEP calls to include the element type (NFC). (cherry picked from commit a7427aa)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
This avoids a regression (correctness and performance) caused by #21262 where we were no longer able to fold away the isnull assertion in the case where the source also contains an explicit isassigned check. Also upgrade many other CreateInBoundsGEP calls to include the element type (NFC). (cherry picked from commit a7427aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array buffers with boxed and unboxed data do not alias. Expose this info to LLVM.