Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #20406, parse infix ~ as a normal operator #20420

Merged
merged 1 commit into from
Feb 3, 2017
Merged

fix #20406, parse infix ~ as a normal operator #20420

merged 1 commit into from
Feb 3, 2017

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added this to the 0.6.0 milestone Feb 2, 2017
@JeffBezanson JeffBezanson added breaking This change will break code parser Language parsing and surface syntax labels Feb 2, 2017
@ararslan ararslan mentioned this pull request Feb 3, 2017
Closed
@StefanKarpinski StefanKarpinski mentioned this pull request Feb 3, 2017
Closed
3 tasks
@stevengj
Copy link
Member

stevengj commented Feb 3, 2017

Should this be added to the list of dottable operators? (Currently, ~ is special-cased in prec-assignment.)

@stevengj
Copy link
Member

stevengj commented Feb 3, 2017 •
edited
Loading

Needs listing in NEWS. Was the old behavior of ~ documented anywhere that needs changing now?

@StefanKarpinski
Copy link
Member

Weirdly small change. I knew this wouldn't be massive, but I didn't realize it would be this small.

@JeffBezanson JeffBezanson merged commit c52bad9 into master Feb 3, 2017
@tkelman tkelman deleted the jb/tilde branch February 3, 2017 18:37
@stevengj
Copy link
Member

stevengj commented Feb 3, 2017

You forgot to add it to the dottable-operators list?

@JeffBezanson
Copy link
Member Author

I guess we can add it to the dottable operators list, I just don't know what it's for so it's hard to know whether it makes sense.

@stevengj
Copy link
Member

stevengj commented Feb 3, 2017

The general rule in 0.6 is that every operator is dottable, precisely so that the caller can decide whether to broadcast them.

@StefanKarpinski
Copy link
Member

Sure, why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking This change will break code parser Language parsing and surface syntax
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JeffBezanson @stevengj @StefanKarpinski