Skip to content

Fix readlines(::Cmd), was accidentally broken in #20203 #20281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2017
Merged

Fix readlines(::Cmd), was accidentally broken in #20203 #20281

merged 2 commits into from
Jan 29, 2017

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jan 27, 2017

tkelman referenced this pull request Jan 27, 2017
@mpastell @StefanKarpinski
add positional chomp argument to readline (squashed #19944)
33f9184
@kshyatt kshyatt added bugfix This change fixes an existing bug io Involving the I/O subsystem: libuv, read, write, etc. labels Jan 27, 2017
@tkelman tkelman requested a review from stevengj January 29, 2017 03:41
@tkelman
redirect stderr to DevNull when running test from #20232
443893d 
suppresses surprising output of
ERROR: Some tests did not pass: 2 passed, 2 failed, 0 errored, 0 broken.
@tkelman tkelman merged commit 61b85e1 into master Jan 29, 2017
@tkelman tkelman deleted the tk/readlines-cmd branch January 29, 2017 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkelman @stevengj @kshyatt